Fix trailing comma support in import type attributes #61922
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript currently allows trailing commas in dynamic import attributes but not in type-level import attributes, creating an inconsistency in the language.
Problem
Root Cause
The
parseImportTypefunction insrc/compiler/parser.tsdid not support trailing commas after the import attributes object, while the dynamic import parsing logic (which usesparseDelimitedList) properly handles trailing commas.Solution
Modified
parseImportTypeto allow an optional trailing comma after parsing import attributes:After This Fix
All these syntax variations now work consistently:
Testing
importTypeTrailingComma.tscovering all trailing comma scenariosFixes #61916.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
plugins.dprint.dev/home/REDACTED/work/TypeScript/TypeScript/node_modules/dprint/dprint fmt(dns block)www.typescriptlang.orgcurl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.