Skip to content

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 4, 2025

Those are newly functional since #61668

Copilot AI review requested due to automatic review settings August 4, 2025 08:00
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Aug 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test cases for contextual parameter type assignment in nested return type inference scenarios. The tests verify that TypeScript correctly infers parameter types when functions are used in nested contexts where the return type must align with expected interfaces.

  • Add four new test files demonstrating different variations of the type inference scenario
  • Tests focus on ensuring parameter a is correctly inferred as string type in nested function contexts
  • Baseline files confirm the expected type inference behavior is working correctly

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
contextualParamTypeVsNestedReturnTypeInference1.ts Basic test case with simple Effect interface and function parameter inference
contextualParamTypeVsNestedReturnTypeInference2.ts Extended test with complex conditional type inference for Effect parameters
contextualParamTypeVsNestedReturnTypeInference3.ts Simplified conditional types without explicit never checks
contextualParamTypeVsNestedReturnTypeInference4.ts Most basic test with direct type parameter passing to effectGen
Multiple baseline files Expected type and symbol outputs for the test cases

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 8, 2025
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Dec 8, 2025
@jakebailey jakebailey enabled auto-merge (squash) December 8, 2025 17:45
@jakebailey jakebailey merged commit dafed7f into microsoft:main Dec 8, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants