fix(checker): Allow element access expressions in computed property names if argument is literal #62968
+45
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25083.
This PR relaxes the check for computed property names in type literals (specifically in
isLateBindableAST) to allowElementAccessExpressionwhen the argument is a static literal.Changes
isLateBindableASTto use a new helperisLateBindableExpression.isLateBindableExpressionrecursively checks the expression and allows:Enum['key'])Enum[-1])Enum[('key')])Example
Verified with new test case
tests/cases/compiler/enumKeysInTypeLiteral.tscovering these scenarios.