Abstract properties #7184
Merged
Abstract properties #7184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all the infrastructure is in place, so I just allowed abstract properties+accessors and added an error when abstract accessors do not have the same abstractness specified.
1. Positive tests. 2. Negative tests. 3. Update error messages. 4. Remove errors from conformance test.
Closed
Member
|
👍 |
src/compiler/diagnosticMessages.json
Outdated
| "category": "Error", | ||
| "code": 2675 | ||
| }, | ||
| "Accessors must both be abstract or not abstract.": { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4669.
The change is extremely small because almost all the machinery is already in place. I decided to give an error for an accessor with one abstract and one not-abstract member. I couldn't come up with a good example with mixed abstractness.