Make hooks location check consistent #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
approved these changes
May 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking that GVFS.Hooks.exe matches the version of GVFS.exe, GVFS is currently using where.exe to find GVFS.Hooks.exe on the path. However, when actually running GVFS.Hooks.exe, it uses the file that is in the same directory as GVFS.exe.
This PR removes usage of where.exe for consistency, instead using the directory of gvfs.exe to locate GVFS.Hooks.exe in all cases.
Combined with !1835, this change fixes an error case when a user uninstalls GVFS then reinstalls into a different directory, where existing clones still point to the old directory and will hit errors when mounting.