Prefetch in background when cloning if pack indexes are not trusted #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickstolee
approved these changes
Jul 8, 2025
| ReturnCode result = this.Execute<PrefetchVerb>( | ||
| enlistment, | ||
| verb => | ||
| bool trustPackIndexes = enlistment.GetTrustPackIndexesConfig(); |
Contributor
There was a problem hiding this comment.
I see that this is already being loaded in the prefetch command, so we don't pass this as an option to the prefetch command as a CLI argument. That took me a tiny bit to figure out, so I thought it worth mentioning.
mjcheetham
approved these changes
Jul 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since prefetch can be quite long for large repos if pack indexes from the server are not trusted (ie need to be built locally after the pack files are downloaded), start prefetch as a separate background process in that case.
See also #1848 for making more history operations usable while the prefetch is still running.