Enforce minimum Windows API set, and loosen SDK requirement checks #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce a minimum Windows API version of build 16299 (aka '1709', aka 'Redstone 3', aka 'Fall Creators Update'). This was the previous target SDK version before 240f73e changed the native projects to use the latest Windows SDK installed. Setting the TargetPlatformMinVersion property for the native projects will prevent use of APIs newer that the specified version, with newer Windows SDKs. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Since we now build with the latest installed Windows SDKs (whilst still enforcing a minimum API compatibility), we can delete this check for a specific Windows SDK installation. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VFS for Git requires the Windows Projected File System ('ProjFS') to function, which was first introduced, in its non-final API design, with Windows 10 build 16299 (aka '1709', 'Redstone 3', 'Fall Creators Update').
Since 240f73e, we now use the latest installed version of the Windows SDK to build the native projects. To prevent accidental use of APIs introduced after 16299, we should set the
TargetPlatformMinVersionproperty to 10.0.16299.0.Whilst we are here, we should also remove the now overzealous checks for the specific Windows SDK in the Build.bat script.
Note that the GitHub
windows-2025runner does not advertise that it has Windows SDK build 16299 installed, but it must do for the current builds to work.