Skip to content

ReadObjectHook: suppress false positive #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dscho merged 1 commit into from
Sep 24, 2025
Merged

ReadObjectHook: suppress false positive #1874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions GVFS/GVFS.ReadObjectHook/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ int main(int, char *argv[])
DisableCRLFTranslationOnStdPipes();

packet_txt_read(packet_buffer, sizeof(packet_buffer));
if (strcmp(packet_buffer, "git-read-object-client"))
if (strcmp(packet_buffer, "git-read-object-client")) // CodeQL [SM01932] `packet_txt_read()` either NUL-terminates or `die()`s
{
die(ReadObjectHookErrorReturnCode::ErrorReadObjectProtocol, "Bad welcome message\n");
}

packet_txt_read(packet_buffer, sizeof(packet_buffer));
if (strcmp(packet_buffer, "version=1"))
if (strcmp(packet_buffer, "version=1")) // CodeQL [SM01932] `packet_txt_read()` either NUL-terminates or `die()`s
{
die(ReadObjectHookErrorReturnCode::ErrorReadObjectProtocol, "Bad version\n");
}
Expand All @@ -105,7 +105,7 @@ int main(int, char *argv[])
packet_flush();

packet_txt_read(packet_buffer, sizeof(packet_buffer));
if (strcmp(packet_buffer, "capability=get"))
if (strcmp(packet_buffer, "capability=get")) // CodeQL [SM01932] `packet_txt_read()` either NUL-terminates or `die()`s
{
die(ReadObjectHookErrorReturnCode::ErrorReadObjectProtocol, "Bad capability\n");
}
Expand All @@ -125,13 +125,13 @@ int main(int, char *argv[])
while (1)
{
packet_txt_read(packet_buffer, sizeof(packet_buffer));
if (strcmp(packet_buffer, "command=get"))
if (strcmp(packet_buffer, "command=get")) // CodeQL [SM01932] `packet_txt_read()` either NUL-terminates or `die()`s
{
die(ReadObjectHookErrorReturnCode::ErrorReadObjectProtocol, "Bad command\n");
}

len = packet_txt_read(packet_buffer, sizeof(packet_buffer));
if ((len != SHA1_LENGTH + 5) || strncmp(packet_buffer, "sha1=", 5))
if ((len != SHA1_LENGTH + 5) || strncmp(packet_buffer, "sha1=", 5)) // CodeQL [SM01932] `packet_txt_read()` either NUL-terminates or `die()`s
{
die(ReadObjectHookErrorReturnCode::ErrorReadObjectProtocol, "Bad sha1 in get command\n");
}
Expand Down
Loading