Ensure --no-prefetch clone is honored by maintenance #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first prefetch for a large repository can take some time and (if gvfs.trust- pack-indexes is false) heavy CPU and disk resources. If a user cloned with --no-prefetch, let's assume they knew what they were doing and not automatically prefetch after 15 minutes. A typical use-case for --no-prefetch is in a CI pipeline which only needs the head of a branch.
derrickstolee
approved these changes
Nov 20, 2025
Contributor
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
I like the way that you use the state of the data to make this decision, instead of storing some kind of config option. This allows users to automatically "upgrade" to prefetching if they opt-in via a foreground prefetch with gvfs prefetch --commits.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first prefetch for a large repository can take some time and (if gvfs.trust-pack-indexes is false) heavy CPU and disk resources.
If a user cloned with --no-prefetch, let's assume they knew what they were doing and not automatically prefetch after 15 minutes.
A typical use-case for --no-prefetch is in a CI pipeline which only needs the head of a branch.