Fix missing untracked files when created in subfolder #369
Conversation
GVFS/GVFS.Build/GVFS.props
Outdated
| <PropertyGroup Label="Parameters"> | ||
| <GVFSVersion>0.2.173.2</GVFSVersion> | ||
| <GitPackageVersion>2.20180814.4</GitPackageVersion> | ||
| <GitPackageVersion>2.20181009.1-pr</GitPackageVersion> |
There was a problem hiding this comment.
See microsoft/git#33
A folder entry in the modified paths was not being used as recursive in the case of untracked files. So if there was the entry foo/ in the modified paths, git was not going into any of the folders of foo to look for untracked files.
This had to do with the fact that while using the exclude we were "unexcluding" folders so if we had the file foo/bar/test.txt, we would need the !foo/, !foo/bar/ in order for git to traverse the directories and find the untracked file. We still do that but because we no longer add to the modified paths if there is a parent directory entry, git needs to treat the folder entry as recursive.
| private void CreateFile() | ||
| { | ||
| this.CreateFile("Some content here", Path.GetRandomFileName() + "tempFile.txt"); | ||
| this.CreateFolder("foo"); |
There was a problem hiding this comment.
I'd suggest better names (Level1/Level2?) and constants for these folder names
kewillford
force-pushed
the
untracked_missing
branch
from
7a3994c to
03fba04
Compare
3 participants
Add to the test to create multiple level of folders and files in those folder to make sure they show up as untracked files.
Update the git for windows version that has the fix.
Fixes #358