Easy fixes for 'git push' performance #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things that are super-easy fixes for improving 'git push' performance.
pack.useBitmapstofalseon mount time.By setting the config value, we don't perform these file checks for the object ids that are passed into stdin.
For (1), this PR sets
pack.useBitmapsto false for VFS for Git enlistments. This config value defaults to true, and duringgit pack-objectswe check for the existence of a.bitmapfile for every packfile, even those covered by the multi-pack-index.Each of these checks took 2-3 seconds on my small test. I hope to get better numbers before merging, but want to see our scale tests.