Add support for installing pipelines-agent binaries, but default to installing vsts-agent binaries #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but default to installing vsts-agent binaries as it did prior
jwittner
requested changes
Aug 4, 2023
Member
jwittner
left a comment
jwittner
left a comment
There was a problem hiding this comment.
Great changes! Just a question and one suggestion. Thanks so much for the contribution!
tristanbarcelon
commented
Aug 14, 2023
Contributor
Author
tristanbarcelon
left a comment
tristanbarcelon
left a comment
There was a problem hiding this comment.
Hi @jwittner, I've submitted changes per your request. Are you ok to approve the PR?
Member
|
@tristanbarcelon - available on the PSGallery as 2.0.20-develop. Thanks a ton for the great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binaries come in vsts-agent and pipelines-agent flavors. Former has a dependency on Node6 while latter supports Node10 or later. For users of this module who want to switch to modern tasks that can run on Node10 or newer, they can set AgentType parameter to
pipelines-agentand it will pick the matching resource in Find-VstsAgent.Resolves #42