This repository was archived by the owner on Dec 7, 2021. It is now read-only.
feat: Nested source directories #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
force-pushed
the
tabarlow/nested-dirs
branch
from
3339fe9 to
d745a48
Compare
wbreza
approved these changes
Nov 4, 2020
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Looks great - Added some feedback on whether we should just always default to recursive: true?
| public async getAssets( | ||
| sourceConnectionFolderPath?: string, | ||
| relativePath: boolean = false, | ||
| recursive: boolean = true): Promise<IAsset[]> { |
Contributor
There was a problem hiding this comment.
Any reason to not always have recursive set??
|
|
||
| public listFiles(folderPath: string): Promise<string[]> { | ||
| return this.listItems(path.normalize(folderPath), (stats) => !stats.isDirectory()); | ||
| public async listFiles(folderPath: string, ext?: string, recursive: boolean = false): Promise<string[]> { |
Contributor
There was a problem hiding this comment.
Same, any reason not do always have this as true?
Contributor
Author
There was a problem hiding this comment.
Wasn't sure. Was leaving it open for flexibility, but I'll remove that param
tbarlow12
force-pushed
the
tabarlow/nested-dirs
branch
2 times, most recently
from
884b883 to
068fbdc
Compare
tbarlow12
force-pushed
the
tabarlow/nested-dirs
branch
from
068fbdc to
1911324
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability of using all nested assets within a source directory.
Addresses #839