Fix lambda captures and exception handling in HCS static initialization #13977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Addresses code review feedback on PR #13971 by fixing lambda capture lists and improving exception handling in
GetProcessorFeatures()andGetSchemaVersion().PR Checklist
Detailed Description of the Pull Request / Additional comments
Lambda capture fix: Changed
[&]to[]in both functions. The lambdas don't capture any variables from the enclosing scope - they only modify static variables which are directly accessible without capture.Exception handling improvement: Changed static cached values from direct types to
std::optional<T>:std::vector<std::string>→std::optional<std::vector<std::string>>std::pair<uint32_t, uint32_t>→std::optional<std::pair<uint32_t, uint32_t>>Return statements now use
.value()to explicitly unwrap the optional. This makes initialization state unambiguous: ifstd::call_oncecompletes successfully, the optional is set; if it throws, execution never reaches the return statement.Validation Steps Performed
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.