Conversation
danielayala94
requested review from
hulumane,
loneursid,
pmpurifoy and
sharath2727
ghost
added
the
danielayala94
commented
Aug 5, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
hulumane
reviewed
Aug 6, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Hack to address AppLifecycle regression introduced in main * Code cleanup * Code cleanup * Addressing PR feedback * Adding bare bone unit test to avoid future regression Co-authored-by: Eric Langlois <erlangl@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* LRP fixes * In progress * Revert "In progress" This reverts commit d5d021a. * Add fixes to E2E testing * Address nits * Added nits from other PR and fixed PushNotificationUtiilty * Use string converter with payload length * Update APITests.cpp * Include AppLifecycle fix for PushArgs * Revert "Include AppLifecycle fix for PushArgs" This reverts commit 33994da. * Addressing nits * Add Verify.h to demo app for helper function * Added TAEF dependencies to Demo/TestApp Co-authored-by: Daniel Ayala <14967941+danielayala94@users.noreply.github.com>
Contributor
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Eric Langlois <erlangl@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
loneursid
approved these changes
Oct 13, 2021
Contributor
loneursid
left a comment
loneursid
left a comment
There was a problem hiding this comment.
Lifting the block, as the latest FrameworkUDK as been ingested into main
ChrisGuzak
reviewed
Nov 24, 2021
| @@ -9,7 +9,8 @@ namespace winrt::Microsoft::Windows::AppLifecycle::implementation | |||
| // Registration constant values. | |||
| static PCWSTR c_argumentPrefix{ L"----" }; | |||
Member
There was a problem hiding this comment.
use const or constexpr instead of static. statis results in unique copies of the variables in every translation unit that includes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Push Notifications Long Running Process (LRP), a component that is intended to receive push notifications from unpackaged apps (including those packaged apps where the Windows build doesn't have BI support - see BackgroundTaskBuilder.SetTaskEntryPointClsid(Guid) API).
The scope of this change is limited to implement the lifetime of the LRP. Full push notifications support will be added in subsequent PRs.
The Windows App SDK layer will talk to the LRP through COM. Because of the current limitations on WinRT for OOP COM servers, we use a proxy stub and WRL APIs.
With the current approach, the LRP shuts down 30 seconds after launching. In subsequent PRs, we will add the logic to persist it and maintain the 30-second timer in case the LRP is not needed at the time.
We are also including a Startup Task, which will launch the LRP on user log on.
How tested: Manually triggered startup task and LRP exe, verifying that CreateInstance was called in the case of the startup task. Also verified that LRP shut down after 30 seconds. Included a unit test to verify we were able to CoCreate a LRP instance.