Refactored utf16->utf8 support from DynDep to common#1513
Merged
DrusTheAxe merged 1 commit intomainfrom Oct 4, 2021
Merged
Conversation
DrusTheAxe
added
the
area-DynamicDependencies
DrusTheAxe
requested review from
dhoehna,
dkbennett,
evelynwu-msft,
huichen123,
hulumane,
pmpurifoy and
sharath2727
ghost
added
the
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
requested review from
EHO-makai,
huzaifa-d and
jonwis
and removed request for
hulumane
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hulumane
approved these changes
Oct 1, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
asklar
reviewed
Oct 5, 2021
| return ToUtf16<winrt::hstring>(utf8); | ||
| } | ||
|
|
||
| // UTF16->UTF8 conversions |
Member
There was a problem hiding this comment.
@DrusTheAxe could you clarify why are all these needed / why don't we use winrt::to_hstring and winrt::to_string ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved DynamicDependency's
to_utf8functions toMicrosoft.Utf8.h(and renamedToUtf8) as the complementary inverse of theToUtf16functions already there.Deleted DynDep's now-obsolete
utf8.hand changed to theMicrosoft.Utf8namespace functions. All tests pass as expected