Refactoring PushNotification unit tests #2389
Merged
Conversation
pmpurifoy
requested review from
David-Quero,
danielayala94,
hulumane,
loneursid and
sharath2727
ghost
added
the
danielayala94
requested changes
Apr 12, 2022
Contributor
danielayala94
left a comment
danielayala94
left a comment
There was a problem hiding this comment.
Great to see this change coming! 😊 Please revert the changes in PowerNotification tests and address the remaining comments in our tests.
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
hulumane
reviewed
Apr 12, 2022
Contributor
Author
|
@DrusTheAxe This PR adds the PushNotificationsLongRunningProcess to the test Singleton msix package and adds it as a default package to install in TAEF testing. Let me know if you don't want it as part of the default packages installed and we can discuss an alternative. |
danielayala94
added
area-Notifications
David-Quero
reviewed
Apr 14, 2022
hulumane
reviewed
Apr 14, 2022
hulumane
reviewed
Apr 14, 2022
hulumane
reviewed
Apr 14, 2022
DrusTheAxe
reviewed
Apr 16, 2022
DrusTheAxe
approved these changes
Apr 16, 2022
hulumane
reviewed
Apr 18, 2022
hulumane
reviewed
Apr 18, 2022
hulumane
reviewed
Apr 18, 2022
hulumane
reviewed
Apr 18, 2022
hulumane
reviewed
Apr 18, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hulumane
approved these changes
Apr 19, 2022
danielayala94
approved these changes
Apr 19, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the PushNotification unit tests to fully run inside TAEF instead of a separate test app exe. Failures are now diagnosable from TAEF output.