Initial implementation of AppLifecycle and ActivationRegistrationManager APIs.#268
Merged
Initial implementation of AppLifecycle and ActivationRegistrationManager APIs.#268
Conversation
… interfaces on the event args classes.
Remove shared samples completely.
…for v1). Make GetActivatedEventArgs defer to the platform for packaged apps.
ghost
added
the
Closed
jonwis
requested changes
Oct 30, 2020
dabhattimsft
approved these changes
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
EHO-makai
reviewed
Oct 30, 2020
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
|
||
| namespace Microsoft.ProjectReunion |
Contributor
There was a problem hiding this comment.
@jonwis , I was imagining that we would not have anything in "Microsoft.ProjectReuion" namespace. Is this OK?
Member
There was a problem hiding this comment.
For now it is, but we should probably move this to Ms.AppModel.Something eventually
EHO-makai
approved these changes
Oct 31, 2020
Contributor
EHO-makai
left a comment
EHO-makai
left a comment
There was a problem hiding this comment.
There will be additional changes for the file activation at which time we may change the namespace,
jonwis
approved these changes
Oct 31, 2020
Member
|
@aeloros please change the title of this PR to have a human-readable one-line-description of this PR (Use the "Edit" button on the top right of the PR page) |
aeloros
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the first set of functionality for the AppLifecycle and ActivationRegistrationManager objects.
Support in this change is scoped to implementation of the LaunchActivatedEventArgs and ProtocolActivatedEventArgs scenarios for unpackaged Win32.
Sample APIs were removed from the tree.
Testing was done by adding basic launch tests, and testing protocol scenarios with a basic sample app. A later PR will contain protocol tests, and a move to the new test framework.