Fix IsPackageDeploymentFeatureSupported#4598
Merged
DrusTheAxe merged 2 commits intomainfrom Jul 25, 2024
Merged
Conversation
DrusTheAxe
added
the
area-WinAppSDKDeployment
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
force-pushed
the
user/drustheaxe/IsFeatureSupported
branch
from
f0b5b21 to
d64e202
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
changed the title
rhuang-msft
approved these changes
Jul 25, 2024
DrusTheAxe
added a commit
that referenced
this pull request
Aug 1, 2024
* Fixed IsPackageDeploymentFeatureSupported * Fixed check for IsReadyOrNewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the
IsPackageDeploymentFeatureSupported()checks forIsPackageReadyOrNewerAvailable(available on some platforms),ResetPackage(not available; vNext) andRepairPackage(not available; vNext)Once in will be brought to shiproom for 1.6 approval
This corrects checks to address KNOWN ISSUES in PackageDeploymentManager: IsReadyOrNewerAvailable(), FrameworkUdk update, Implement not-implemented functions, Tests!
#4453
https://task.ms/52754253