fix for issue 181 and updating the connection#184
Conversation
|
Hi @davidkline-ms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| "dependencies": { | ||
| "Microsoft.NETCore.UniversalWindowsPlatform": "5.1.0" | ||
| "Microsoft.NETCore.UniversalWindowsPlatform": "5.1.0", | ||
| "StyleCop.MSBuild": "4.7.54" |
There was a problem hiding this comment.
I thought we didn't want this to be a dependency?
There was a problem hiding this comment.
fixed. was my mistake to add this file to the change
|
Except for the open question about StyleCop, looks great to me, thanks! |
| @@ -113,7 +113,7 @@ private void ConnectToDevice_Click(object sender, RoutedEventArgs e) | |||
| // remainder of this session. | |||
| if (allowUntrusted) | |||
There was a problem hiding this comment.
I think we can change this allowUntrusted to be "allowUntrusted || <is using http instead of https (eg USB)> ?
There was a problem hiding this comment.
That way they don't have to check the box on HoloLens.
|
I'm having trouble connecting to the Hololens via USB on a new computer. I can connect to this device from another computer so I know it's possible, but the new computer must be missing a setting or something. I've copied every proxy setting, internet options settings, etc I can think of, but still cannot connect. When I go to http://127.0.0.1 (or http://127.0.0.1:10080), I get this chrome browser message: "This site can’t be reached. 127.0.0.1 refused to connect." and ERR_CONNECTION_REFUSED I have WiFi disabled (not allowed to use WiFi behind company firewalls), I have proxy settings correct, developer mode on, Device portal on. As I said, I can connect to this HoloLens from another computer but not my new one. ###What setting am I missing?????? |
This resolves #181 as well as issues with the DefaultDevicePortalConnection implementation of UpdateConnection.
The UpdateConnection change is to add a third parameter to specify whether or not to preserve the original connection's port. On HoloLens and Mobile, the port number is not preserved as the most common use of this is to switch from USB (port 10080) to WiFi (port number based on scheme)
Also implemented are methods to get the correctly formatted URI for accessing the Mixed Reality Capture live stream data on HoloLens.