Skip to content

fix for issue 181 and updating the connection#184

Merged
david-c-kline merged 2 commits into
microsoft:masterfrom
david-c-kline:master
Oct 3, 2016
Merged

fix for issue 181 and updating the connection#184
david-c-kline merged 2 commits into
microsoft:masterfrom
david-c-kline:master

Conversation

@david-c-kline
Copy link
Copy Markdown

This resolves #181 as well as issues with the DefaultDevicePortalConnection implementation of UpdateConnection.

The UpdateConnection change is to add a third parameter to specify whether or not to preserve the original connection's port. On HoloLens and Mobile, the port number is not preserved as the most common use of this is to switch from USB (port 10080) to WiFi (port number based on scheme)

Also implemented are methods to get the correctly formatted URI for accessing the Mixed Reality Capture live stream data on HoloLens.

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 3, 2016

Hi @davidkline-ms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (David Kline (XBOX)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

"dependencies": {
"Microsoft.NETCore.UniversalWindowsPlatform": "5.1.0"
"Microsoft.NETCore.UniversalWindowsPlatform": "5.1.0",
"StyleCop.MSBuild": "4.7.54"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't want this to be a dependency?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. was my mistake to add this file to the change

@hpsin
Copy link
Copy Markdown
Contributor

hpsin commented Oct 3, 2016

Except for the open question about StyleCop, looks great to me, thanks!

@@ -113,7 +113,7 @@ private void ConnectToDevice_Click(object sender, RoutedEventArgs e)
// remainder of this session.
if (allowUntrusted)
Copy link
Copy Markdown
Contributor

@WilliamsJason WilliamsJason Oct 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change this allowUntrusted to be "allowUntrusted || <is using http instead of https (eg USB)> ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way they don't have to check the box on HoloLens.

@nadine505
Copy link
Copy Markdown

I'm having trouble connecting to the Hololens via USB on a new computer. I can connect to this device from another computer so I know it's possible, but the new computer must be missing a setting or something. I've copied every proxy setting, internet options settings, etc I can think of, but still cannot connect. When I go to http://127.0.0.1 (or http://127.0.0.1:10080), I get this chrome browser message: "This site can’t be reached. 127.0.0.1 refused to connect." and ERR_CONNECTION_REFUSED

I have WiFi disabled (not allowed to use WiFi behind company firewalls), I have proxy settings correct, developer mode on, Device portal on. As I said, I can connect to this HoloLens from another computer but not my new one.

###What setting am I missing??????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot connect to HoloLens over USB

6 participants