New SampleDeviceCollection#192
Conversation
…vicePortalCommand model
…eestablish connection retry loop. Made rename more robust. Stronger check for duplicates using the cannonical IP address
|
Hi @GregPettyjohn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| *.user | ||
| *.userosscache | ||
| *.sln.docstates | ||
| sync.cmd |
There was a problem hiding this comment.
did I accidentally commit this file? sorry :(
WilliamsJason
left a comment
WilliamsJason
left a comment
There was a problem hiding this comment.
I don't have a ton of time so I looked over this very quickly, but it looks good to me from what I saw. We should give other folks a bit of time to look over it but I'm happy to accept the PR in a day or two if nobody else has time to review it further.
| } | ||
| } | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Looks like your rename to DefaultDevicePortalConnection got lost here. Also, I'll close the other PR that did this since that one is out-of-date.
|
Signing off on this as well. Only ran into a couple snags:
Couldn't get my HoloLens VM up and running, the storm over the weekend hosed it, but IoT, PC, and mobile all worked great otherwise. |
5 participants
Sample demonstrates a "vertical slice" of the WindowsDevicePortalWrapper. Provides a user interface to connect to and manage multiple devices. Including, renaming devices, rebooting devices, hooking up to performance events, etc. Provides an intuitive sign-in experience that clarifies the port setting and https setting based on the device type. Sample uses WPF + XAML and leverages the MVVM pattern with minimal code-behind. View models are designed to be reusable so that you can leverage them in your own code.