BREAKING CHANGE: ConnectAsync(updateConnection)#211
Merged
Conversation
Contributor
|
s/IoT/phone/ - Phone supports the IPoverUSB connection, as well as HoloLens, but not IoT. In any case, this should not impact materially, except in the case that the user expected the connection to switch to WiFi from USB. Thanks for this! Should we consider changing the version number? |
hpsin
approved these changes
Jan 31, 2017
WilliamsJason
approved these changes
Jan 31, 2017
Author
|
we should increment the version. i'll send another pr for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in issue #209:
The new ConnectAsync() behavior defaults to updateConnection == false. Most impacted are HoloLens and IoT devices which support a localhost connection (via USB) from the PC to the device.
To use the old behavior, add "updateConnection: true" to your ConnectAsync() arguments.
This change resolves #209.