Refactored use of async.#215
Merged
Merged
Conversation
… and continue on background threads.
|
Hi @dotMorten, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
dotMorten
commented
Feb 15, 2017
| if (!response.IsSuccessStatusCode) | ||
| { | ||
| throw new DevicePortalException(response); | ||
| throw await DevicePortalException.CreateAsync(response); |
Contributor
Author
There was a problem hiding this comment.
You shouldn't have async code in a constructor, so I changed the exception creation to be a static async creator (see further down), and changed all uses of it to this instead.
Contributor
Author
|
Hold off on review... I just saw a lot of use of .Wait(). That's also a big no-no and causes deadlocks. Will update PR... |
…onfigureAwait, and remove await where not needed
…tch to ui thread, it's easier to just await and continue on the same thread here.
Contributor
Author
|
ok ready for review @WilliamsJason |
WilliamsJason
approved these changes
Feb 15, 2017
Contributor
WilliamsJason
left a comment
WilliamsJason
left a comment
There was a problem hiding this comment.
Awesome stuff, thanks!
dotMorten
added a commit
to dotMorten/WindowsDevicePortalWrapper
that referenced
this pull request
Feb 15, 2017
Refactored use of async. (microsoft#215)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No tight while-loops but instead using await and continue on background threads.
Addresses #214
@WilliamsJason