Conversation
Alters WebSocket parsing routine.
Contributor
Author
|
Once this is in and @dotMorten's App install changes are in, I want to spin a new release for @davidkline-ms |
CBaud
approved these changes
Feb 18, 2017
Contributor
CBaud
left a comment
CBaud
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a few things - generation of new EtwEventInfo objects from a Dictionary<string, string>, because DataContractJsonSerializer can't fit them directly, and changes the WebSocket JSON deserialization step to use a Simple Dictionary Format, which is required to get the Dictionary<string, string> in the first place.
Would appreciate review of the way the EtwEventInfo object is created and cached since I'm a bit surprised C# allowed it in the first place.