Issue #29: WindowsErrorReporting is unimplemented#224
Merged
Conversation
|
@CBaud, |
I had to dig into behavior to figure this out and test across multiple devices to figure out how this API actually worked - hopefully this helps other developers not have to do the same thing
hpsin
approved these changes
Feb 27, 2017
Contributor
hpsin
left a comment
hpsin
left a comment
There was a problem hiding this comment.
This looks great! I wish the REST API was better suited to creating something nice here, but you did the best that was possible :)
Thank you!
| /// <param name="file">The name of the file to download from the report.</param> | ||
| /// <returns>Byte array containing the file data</returns> | ||
| public async Task<byte[]> GetWindowsErrorReportingFileAsync(string user, string type, string name, string file) | ||
| { |
Contributor
There was a problem hiding this comment.
This signature really points out how bad our REST API is - have to get fields from 2 different requests and 3 different objects to fill this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.