Allow known attributes with customized namespace prefix on xliff elements#34
Open
arnoldbeiland wants to merge 1 commit intomicrosoft:masterfrom
Open
Allow known attributes with customized namespace prefix on xliff elements#34arnoldbeiland wants to merge 1 commit intomicrosoft:masterfrom
arnoldbeiland wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
Hi @arnoldbeiland Unfortunately, this project is dead. However, I created a new fork: Xliff.OM.NetStandar with all latest bugfixes including your changes. The corresponding Nuget package is also updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Not checking the namespace prefix name seemed to be the solution for the bug linked.
However we also have to take care of cases where there are multiple attributes on an element with the same name (from different namespaces). See the test files from the commit: