.NET: Adding feature collections ADR#3332
Merged
westey-m merged 1 commit intomicrosoft:mainfrom Jan 22, 2026
Merged
Conversation
4 tasks
SergeyMenshykh
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds an Architectural Decision Record (ADR) for feature collections and includes references to four other new ADR documents in the solution file. The main ADR (0014-feature-collections.md) documents the decision to use AdditionalProperties dictionaries instead of a dedicated feature collection implementation for passing arbitrary services or data to agents and components in the agent execution stack.
Changes:
- Added ADR 0014 documenting the feature collections design decision and rationale
- Added references to ADRs 0010-0014 in the .NET solution file for visibility
- Included supporting ADRs for Python-specific decisions (get_response simplification and TypedDict options)
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| dotnet/agent-framework-dotnet.slnx | Added references to five new ADR files (0010-0014) in the solution file for better visibility and navigation |
| docs/decisions/0014-feature-collections.md | New ADR documenting the decision to use AdditionalProperties for feature collections, with detailed analysis of alternatives and sample scenarios |
| docs/decisions/0013-python-get-response-simplification.md | New ADR documenting the Python-specific decision to consolidate streaming and non-streaming methods into a single get_response method |
| docs/decisions/0012-python-typeddict-options.md | New ADR documenting the use of TypedDict with generic type parameters for type-safe chat client options in Python |
markwallace-microsoft
approved these changes
Jan 21, 2026
This was referenced Jan 27, 2026
This was referenced Feb 1, 2026
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Recreating the previous PR #2503 to target the main branch.
Description
Contribution Checklist