Conversation
de443d8 to
4bd50f3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FileSystemJsonCheckpointStore so the index (index.jsonl) is flushed during checkpoint creation, ensuring the on-disk index is up to date when CreateCheckpointAsync returns (addresses #3169).
Changes:
- Flush
index.jsonlafter appending a checkpoint entry inCreateCheckpointAsync. - Add a unit test verifying the index file has non-zero length before the store is disposed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Workflows/Checkpointing/FileSystemJsonCheckpointStore.cs | Flushes the index stream after writing a new checkpoint entry. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/FileSystemJsonCheckpointStoreTests.cs | Adds coverage to ensure index data is persisted prior to store disposal. |
dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/FileSystemJsonCheckpointStoreTests.cs
Show resolved
Hide resolved
4bd50f3 to
86e7226
Compare
westey-m
approved these changes
Jan 26, 2026
86e7226 to
95cb660
Compare
SergeyMenshykh
approved these changes
Jan 26, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flushes the index file on checkpoint creation to ensure we get disk status current when control returns to user code after the checkpoint.
Fixes #3169
Contribution Checklist
Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.