Skip to content

Fix Windows .bat/.cmd shim spawn failure in copilotSdk.ts by adding early-exit to external server mode #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
digitarald merged 4 commits into from
Mar 15, 2026
+13 −6
Merged

Fix Windows .bat/.cmd shim spawn failure in copilotSdk.ts by adding early-exit to external server mode #53

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63bb6c0
Checkpoint from Copilot CLI for coding agent session
nicolehaugen Mar 12, 2026
094f3cd
Checkpoint from Copilot CLI for coding agent session
nicolehaugen Mar 12, 2026
d5119e7
fix: Windows .bat/.cmd shim spawn EINVAL - early-exit to external ser…
Copilot Mar 12, 2026
737d01d
fix: address review feedback - remove tsup/docs files, inline isBatSh…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/core/src/services/copilotSdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ function shouldFallbackToExternalServer(error: unknown): boolean {
return (
message.includes("unknown option '--headless'") ||
message.includes("unknown option '--no-auto-update'") ||
message.includes("copilot cli not found")
// SDK's internal CLI resolution couldn't find the binary
message.includes("copilot cli not found") ||
// Node's spawn() can't execute .bat/.cmd directly on Windows
message.includes("spawn einval")
);
}

Expand Down Expand Up @@ -215,12 +218,16 @@ export async function createCopilotClient(
: cliConfig.cliPath;
logCopilotDebug(`creating SDK client with cliPath=${desc} useStdio=false`);

// npx spawns a grandchild process (npx -> node -> copilot) that the SDK
// cannot clean up — killing npx leaves the copilot binary running.
// Use external server mode where we manage the process tree ourselves.
// npx spawns a grandchild (npx → node → copilot) the SDK can't clean up.
// Windows .bat/.cmd shims can't be spawned directly by Node's child_process.
// In both cases, skip the SDK-managed attempt and go straight to external server.
const isNpx = /\bnpx(?:\.cmd)?$/iu.test(cliConfig.cliPath);
if (isNpx) {
logCopilotDebug("npx wrapper detected; using external server mode");
const isBatShim = process.platform === "win32" && /\.(?:bat|cmd)$/iu.test(cliConfig.cliPath);

if (isNpx || isBatShim) {
logCopilotDebug(
`${isNpx ? "npx wrapper" : ".bat/.cmd shim"} detected; using external server mode directly`
);
const external = await startExternalServer(cliConfig);
const client = new sdk.CopilotClient({ cliUrl: external.cliUrl });
try {
Expand Down
Loading