Bug: Hook integrator does not process 'windows' property – scripts not copied and paths not rewritten

[danielmeppiel]

Bug Description

When a hook file (.apm/hooks/*.json) contains a windows property alongside command, bash, or powershell, the windows property is not processed during compilation/installation. This means:

1. Script files referenced in the windows property are not copied to .github/hooks/scripts/
2. Paths in the windows property are not rewritten to the installed location (e.g. .github/hooks/scripts/dotnet/secrets-scanner/scan-secrets.ps1)

Only the command, bash, and powershell properties work correctly.

Root Cause Analysis

File: src/apm_cli/integration/hook_integrator.py — lines 234 and 248

The hook path-rewriting code iterates over a hardcoded tuple of keys that does not include "windows":

# Line 234 – GitHub Copilot flat format (matcher-level)
for key in ("command", "bash", "powershell"):
    if key in matcher:
        new_cmd, scripts = self._rewrite_command_for_target(
            matcher[key], package_path, package_name, target,
            hook_file_dir=hook_file_dir,
        )
        matcher[key] = new_cmd
        all_scripts.extend(scripts)

# Line 248 – Claude nested format (hooks array)
for key in ("command", "bash", "powershell"):
    if key in hook:
        new_cmd, scripts = self._rewrite_command_for_target(
            hook[key], package_path, package_name, target,
            hook_file_dir=hook_file_dir,
        )
        hook[key] = new_cmd
        all_scripts.extend(scripts)

Because "windows" is missing from the tuple in both locations, the _rewrite_command_for_target() function is never called for that key, so scripts are not copied and paths are not rewritten.

History

Commit 39e4c4d previously fixed this same class of bug by adding bash and powershell to the tuple (previously only command was handled). The windows key was overlooked in that fix.

Suggested Fix

Add "windows" to the key tuple in both locations (lines 234 and 248):

for key in ("command", "bash", "powershell", "windows"):

Or more robustly, consider dynamically processing all keys that may contain script path references to prevent similar omissions in the future.

Steps to Reproduce

1. Create a package with a hook in .apm/hooks/ that has a windows property pointing to a script
2. Run apm install or apm compile
3. Observe that files from command are copied to .github/hooks/ but files from windows are not
4. Observe that windows paths remain as original relative paths instead of being rewritten

[dstamand-msft]

Extra notes

1. The hooks.json support other properties than windows, such as osx and linux. Both should have the same behavior.

2. Hooks events for VSCode (IDEs) currently differ from Hooks events from GitHub Copilot Agent (GitHub platform)

If a hooks.json is to be rewritten to be added to VSCode .github folder, only the VSCode hooks should be taken care of
See https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-lifecycle-events

A warning can be given if ever GitHub Copilot Hooks are found. See https://docs.github.com/en/copilot/how-tos/use-copilot-agents/coding-agent/use-hooks#creating-a-hook-in-a-repository-on-github

currently my apm integrates both json files (one for Copilot Agent and one for VSCode)

[dstamand-msft]

Issue still seems to be exist for the path rewriting and file copying.

My hooks file in my apm package:

{
  "hooks": {
    "Stop": [
      {
        "type": "command",
        "command": "./secrets-scanner/scan-secrets.sh",
        "windows": "pwsh -File .\\secrets-scanner\\scan-secrets.ps1"
      },
      {
        "type": "command",
        "command": "./session-auto-commit/auto-commit.sh",
        "windows": "pwsh -File .\\session-auto-commit\\auto-commit.ps1"
      }      
    ]
  }
}

hooks file in the .github folder post processing:

{
  "hooks": {
    "Stop": [
      {
        "type": "command",
        "command": ".github/hooks/scripts/dotnet/secrets-scanner/scan-secrets.sh",
        "windows": "pwsh -File .\\secrets-scanner\\scan-secrets.ps1"
      },
      {
        "type": "command",
        "command": ".github/hooks/scripts/dotnet/session-auto-commit/auto-commit.sh",
        "windows": "pwsh -File .\\session-auto-commit\\auto-commit.ps1"
      }
    ]
  }
}

command was properly rewritten but not windows and the ps1 files are not copied.

Would the backslash cause problem?