-
Notifications
You must be signed in to change notification settings - Fork 155
Add air-gapped/GHE configurability to install.ps1 (Windows parity) #668
Copy link
Copy link
Open
Labels
area/distributionInstallers (curl/PowerShell/Brew/Scoop), self-update, devcontainer, codespaces.Installers (curl/PowerShell/Brew/Scoop), self-update, devcontainer, codespaces.area/docs-sitedocs/src/content (Starlight), README, doc generation.docs/src/content (Starlight), README, doc generation.enhancementDeprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.Deprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.good first issueGood for newcomersGood for newcomerspriority/lowAccepted but not time-sensitiveAccepted but not time-sensitivestatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).theme/portabilityOne manifest, every target. Multi-target deploy, marketplace, packaging, install.One manifest, every target. Multi-target deploy, marketplace, packaging, install.type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Milestone
Metadata
Metadata
Assignees
Labels
area/distributionInstallers (curl/PowerShell/Brew/Scoop), self-update, devcontainer, codespaces.Installers (curl/PowerShell/Brew/Scoop), self-update, devcontainer, codespaces.area/docs-sitedocs/src/content (Starlight), README, doc generation.docs/src/content (Starlight), README, doc generation.enhancementDeprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.Deprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.good first issueGood for newcomersGood for newcomerspriority/lowAccepted but not time-sensitiveAccepted but not time-sensitivestatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).theme/portabilityOne manifest, every target. Multi-target deploy, marketplace, packaging, install.One manifest, every target. Multi-target deploy, marketplace, packaging, install.type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Type
Projects
Status
In Progress
Summary
PR #660 adds configurable env vars to
install.shfor air-gapped and GHE environments (APM_INSTALL_DIR,GITHUB_URL,APM_REPO,VERSION). The Windows installer (install.ps1) should support the same configurability so Windows users get an equivalent experience.Proposed solution
Add the same environment variable support to
install.ps1:APM_INSTALL_DIRapmbinaryGITHUB_URLhttps://github.bokerqi.topAPM_REPOmicrosoft/apmVERSIONKey behaviors to match:
VERSIONis set, skip the GitHub API and construct the download URL directlyGITHUB_URLfor GHE compatibilityirm https://aka.ms/apm-windows | iex -Args @v1.2.3(or equivalent PowerShell pattern)GITHUB_APM_PAT,GITHUB_TOKEN) should work with both API and direct download pathsAcceptance criteria
install.ps1supportsAPM_INSTALL_DIR,GITHUB_URL,APM_REPO,VERSIONenv varsGITHUB_URLRelated