-
Notifications
You must be signed in to change notification settings - Fork 156
Cowork diagnostic polish — hide experimental key and fix verbose log #923
Copy link
Copy link
Open
Labels
area/cliCLI command surface, flags, help text (cross-cutting).CLI command surface, flags, help text (cross-cutting).area/multi-targetMulti-target deploy spec, target directory creation, agent surface routing.Multi-target deploy spec, target directory creation, agent surface routing.enhancementDeprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.Deprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.experimentalstatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).type/bugSomething does not work as documented.Something does not work as documented.
Metadata
Metadata
Assignees
Labels
area/cliCLI command surface, flags, help text (cross-cutting).CLI command surface, flags, help text (cross-cutting).area/multi-targetMulti-target deploy spec, target directory creation, agent surface routing.Multi-target deploy spec, target directory creation, agent surface routing.enhancementDeprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.Deprecated: use type/feature. Kept for issue history; will be removed in milestone 0.10.0.experimentalstatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).type/bugSomething does not work as documented.Something does not work as documented.
Type
Projects
Status
Done
Follow-up to #913. Surfaced by the APM Expert Review Panel (CLI Logging specialist). MEDIUM severity, cosmetic / discoverability. CEO arbitration: acceptable as follow-ups.
1.
_valid_config_keys()leakscowork-skills-dirwhen flag is offFile:
src/apm_cli/commands/config.py:56(approx)cowork-skills-diralways appears in the valid-keys list used for error messages. A user with thecoworkflag disabled sees this key in "unknown config key" suggestions — leaks experimental surface awareness.Display-side gating is already correct in
apm config list(the row is hidden when the flag is off). Mirror that pattern here.Fix: gate
cowork-skills-dirin_valid_config_keys()onexperimental.is_enabled("cowork").unsetpath stays ungated (safety valve).2. Verbose target log prints placeholder
root_dirinstead of resolved OneDrive pathFile:
src/apm_cli/install/phases/targets.py:70-71The
--verbosetarget listing printscowork (~/cowork/)— the placeholderroot_dirfrom theTargetProfileconstructor — instead of the real resolved OneDrive path. Debugging output becomes actively misleading.Fix: when logging cowork, prefer
target.resolved_deploy_root(ortarget.deploy_path()result) overtarget.root_dir.Acceptance criteria
apm config set unknown-key valuewithcoworkflag OFF does not mentioncowork-skills-dirin the valid-keys list; with flag ON it does.apm install --target cowork --global --verboseprints the actual resolved OneDrive directory./cc panel review: #913