Skip to content

fix: rename token variable to resolve CodeQL clear-text-storage alert #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 4 commits into from
Apr 28, 2026
Merged

fix: rename token variable to resolve CodeQL clear-text-storage alert #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e489709
Initial plan
Copilot Apr 27, 2026
30bfdb9
Plan: fix CodeQL clear-text storage alert in plugin_parser.py
Copilot Apr 27, 2026
976355e
fix: rename `token` to `placeholder` in _substitute_plugin_root to re…
Copilot Apr 27, 2026
0293d89
Merge branch 'main' into copilot/fix-clear-text-storage-sensitive-data
sergio-sisternes-epam Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/apm_cli/deps/plugin_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,14 +276,14 @@ def _substitute_plugin_root(
servers: Dict[str, Any], abs_root: str, logger: logging.Logger
) -> Dict[str, Any]:
"""Replace ``${CLAUDE_PLUGIN_ROOT}`` in server config string values."""
token = "${CLAUDE_PLUGIN_ROOT}"
placeholder = "${CLAUDE_PLUGIN_ROOT}"
substituted = False

def _walk(obj: Any) -> Any:
nonlocal substituted
if isinstance(obj, str) and token in obj:
if isinstance(obj, str) and placeholder in obj:
substituted = True
return obj.replace(token, abs_root)
return obj.replace(placeholder, abs_root)
if isinstance(obj, dict):
return {k: _walk(v) for k, v in obj.items()}
if isinstance(obj, list):
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading