fix: use POSIX paths in auto-discovery CLI output for Windows compat

[sergio-sisternes-epam]

Problem

The CI/CD Pipeline is broken on Windows (run 25036652822). Two unit tests in test_script_formatters.py fail because Path.__str__() uses backslash separators on Windows:

FAILED test_format_auto_discovery_message_rich_fallback
  AssertionError: 'prompts/hello.md' not found in '[i] Auto-discovered: prompts\hello.md (runtime: copilot)'

FAILED test_format_auto_discovery_message_success
  AssertionError: 'scripts/deploy.prompt.md' not found in '[i] Auto-discovered: scripts\deploy.prompt.md (runtime: codex)'

Fix

Use Path.as_posix() instead of str(path) / f"{path}" in three sites within script_formatters.py and one in script_runner.py. This ensures consistent forward-slash output regardless of platform.

Files changed

• src/apm_cli/output/script_formatters.py -- 3 interpolation sites in format_auto_discovery_message
• src/apm_cli/core/script_runner.py -- 1 print statement in execute

Validation

6,627 unit tests pass locally (macOS). The fix is a minimal, surgical change with no behavioural impact beyond normalising path display.

[Copilot]

Pull request overview

Normalizes auto-discovery path rendering in CLI output to be stable across platforms (notably Windows), addressing unit test failures caused by backslash path separators.

Changes:

• Switched auto-discovery message formatting to use Path.as_posix() instead of implicit str(Path) in ScriptExecutionFormatter.
• Switched the early auto-discovery print() in ScriptRunner.run_script() to use as_posix() for consistent forward-slash output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/apm_cli/output/script_formatters.py	Ensures auto-discovery messages render prompt paths with POSIX separators in both rich and fallback branches.
src/apm_cli/core/script_runner.py	Ensures the early auto-discovery print uses POSIX separators for Windows-compatible output and tests.

[github-actions]

APM Review Panel Verdict

Disposition: APPROVE (with one minor pre-merge action: CHANGELOG entry)

---

Per-persona findings

Python Architect:

This is a routine bug-fix PR (4 lines changed, no new abstractions). One class diagram + one execution-flow diagram apply.

1. OO / class diagram

classDiagram
    direction LR
    class ScriptRunner {
        <<IOBoundary>>
        +run_script(script_name, params) bool
        -_discover_prompt_file(name) Path
        -_detect_installed_runtime() str
        -_generate_runtime_command(runtime, path) str
        -_execute_script_command(command, params) bool
    }
    class ScriptFormatter {
        <<Pure>>
        +format_auto_discovery_message(name, prompt_file, runtime) str
        -_styled(text, style) str
        +use_color bool
        +console Console
    }
    class Path {
        <<ValueObject>>
        +as_posix() str
    }
    ScriptRunner ..> Path : uses (discovered_prompt)
    ScriptRunner ..> ScriptFormatter : delegates formatting
    ScriptFormatter ..> Path : formats for display
    class ScriptRunner:::touched
    class ScriptFormatter:::touched
    classDef touched fill:#fff3b0,stroke:#d47600

Loading

2. Execution flow diagram

flowchart TD
    A([apm run SCRIPT_NAME]) --> B[ScriptRunner.run_script]
    B --> C{script in apm.yml?}
    C -- yes --> D[_execute_script_command]
    C -- no --> E["[FS] _discover_prompt_file(name)"]
    E --> F{prompt found?}
    F -- no --> G[auto-install or error]
    F -- yes --> H["print: [i] Auto-discovered: path.as_posix()"]
    H --> I[_detect_installed_runtime]
    I --> J[_generate_runtime_command]
    J --> D
    D --> K([exit])

    L([format_auto_discovery_message]) --> M{use_color and Rich?}
    M -- yes --> N["Rich Text with prompt_file.as_posix()"]
    N --> O{Rich exception?}
    O -- yes --> P["f-string fallback: prompt_file.as_posix()"]
    O -- no --> Q([return formatted string])
    M -- no --> P
    P --> Q

Loading

3. Design patterns

• Used in this PR: none -- straight-line procedural change, appropriate for scope.
• Pragmatic suggestion: the raw print() in ScriptRunner.run_script() (line ~77 of script_runner.py) duplicates the responsibility of ScriptFormatter.format_auto_discovery_message(), which was purpose-built for this exact message. Routing through the formatter would unify path-display logic into one testable surface. Low-cost follow-up; not a blocker for this PR.

---

CLI Logging Expert: The [i] symbol is correct for an informational discovery message. .as_posix() is applied consistently in all three branches of format_auto_discovery_message() (Rich success path, except Exception fallback, else branch) -- the fix is thorough. The raw print() in script_runner.py is a pre-existing anti-pattern (bypasses CommandLogger/ScriptFormatter lifecycle) that predates this PR; out of scope here but worth a follow-up issue.

---

DevX UX Expert: Windows CLI output showing backslash paths (prompts\hello.md) looks foreign and harms copy-paste ergonomics. Forward slashes match the convention of npm, cargo, pip, and every major CLI tool. No command surface, flags, or help text changed; no cli-commands.md update needed. Pure UX improvement for a significant platform.

---

Supply Chain Security Expert: path.as_posix() is a string rendering call on an already-resolved Path object. No file I/O, no path traversal, no containment guards needed. No credentials or sensitive values appear in this display path. Zero security surface change.

---

Auth Expert: Not activated -- the two changed files (script_runner.py, script_formatters.py) handle prompt discovery and output rendering exclusively; no auth, token management, credential resolution, or host classification logic is touched.

---

OSS Growth Hacker: This fix protects the "first 5 minutes" funnel for Windows users. Garbled backslash paths on a first apm run are a silent conversion killer -- a new Windows user seeing broken output is less likely to continue and less likely to recommend APM. Side-channel to CEO: the CHANGELOG entry at release can be bundled as a "Windows compatibility" beat. The fact that CI caught this regression (run 25036652822) also validates the cross-platform matrix investment -- worth reinforcing in community communications.

---

CEO arbitration

All five mandatory specialists APPROVE unanimously; there are no disagreements to arbitrate. The fix is a correct, minimal, surgical response to a real Windows CI failure with no behavioral regressions across architecture, output UX, developer ergonomics, or security. The OSS Growth Hacker is right that Windows first-run is a concrete conversion surface worth protecting. One required pre-merge action: add a CHANGELOG entry under [Unreleased] per repo conventions -- every behavior-changing PR needs one. A follow-up issue tracking the print()-in-core inconsistency is recommended but does not block this fix.

---

Required actions before merge

1. Add a CHANGELOG entry under ## [Unreleased] in CHANGELOG.md, e.g.:

   ### Fixed
   - Auto-discovery path display now uses forward slashes on Windows (`script_runner.py`, `script_formatters.py`) (#1018)
   

---

Optional follow-ups

• Open a follow-up issue to route the raw print() in ScriptRunner.run_script() through ScriptFormatter.format_auto_discovery_message() -- this would consolidate all path-display logic into one testable site and bring script_runner.py in line with the CommandLogger/ScriptFormatter output architecture.
• Consider adding a Windows-specific test assertion in the existing test_format_auto_discovery_message_* tests that explicitly passes a Windows-style Path (e.g., PureWindowsPath('prompts\\hello.md')) to confirm .as_posix() is invoked, hardening against future regressions on this surface.

Generated by PR Review Panel for issue #1018 · ● 667.8K · ◷