fix(ci): prevent skip-propagation in integration test pipeline#106
Merged
danielmeppiel merged 1 commit intomainfrom Feb 25, 2026
Merged
fix(ci): prevent skip-propagation in integration test pipeline#106danielmeppiel merged 1 commit intomainfrom
danielmeppiel merged 1 commit intomainfrom
Conversation
When approve-fork is skipped (internal PRs), GitHub Actions propagates the skip through the entire dependency chain. Without always(), the if conditions on integration-tests and release-validation are never even evaluated — the jobs are skipped before the condition check. Adding always() overrides skip-propagation so the if condition is actually evaluated, while the result == 'success' check still ensures the job only runs when its dependency genuinely passed. Fixes: https://github.com/microsoft/apm/actions/runs/22402036846
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a GitHub Actions dependency-chain edge case in the ci-integration.yml pipeline where a skipped upstream job (e.g., approve-fork on internal PRs) could cause downstream jobs to be skipped before their if conditions are evaluated.
Changes:
- Add
always()to theintegration-testsjobif:so its condition is evaluated even when upstream jobs were skipped. - Add
always()to therelease-validationjobif:for the same skip-propagation behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In run #22402036846,
integration-testsandrelease-validationwere skipped even thoughsmoke-testsucceeded.Root cause: When
approve-forkis skipped (internal PRs), GitHub Actions propagates the skip through the entire dependency chain — not just direct dependents. Withoutalways(), theifconditions on downstream jobs are never even evaluated; the jobs are skipped before the condition check happens.From the docs:
Fix
Add
always()tointegration-testsandrelease-validationso skip-propagation is overridden and theifcondition is actually evaluated:The
result == 'success'check still ensures each job only runs when its direct dependency genuinely passed.