fix: address unresolved review comments on apm pack/unpack#219
Merged
danielmeppiel merged 2 commits intofeat/pack-unpackfrom Mar 9, 2026
Merged
fix: address unresolved review comments on apm pack/unpack#219danielmeppiel merged 2 commits intofeat/pack-unpackfrom
danielmeppiel merged 2 commits intofeat/pack-unpackfrom
Conversation
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add apm pack and unpack commands
fix: address unresolved review comments on apm pack/unpack
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all unresolved review comments from the
apm pack/apm unpackPR.Security
Path traversal protection (
packer.py,unpacker.py)deployed_filesentry before reading/writing: reject..components, absolute paths, and any path that resolves outsideproject_root/output_dirviaPath.is_relative_to().github/../../../etc/passwdare now rejected with a clearValueErrorBug fixes
unpacker.pytarfile.extractall(filter="data")is Python 3.12+ only; gated behindsys.version_info >= (3, 12)with fallback to manual member checks (already present) for 3.9–3.11UnpackResult.extracted_dirwas returning a deleted temp directory in archive mode — now returns the originalbundle_pathlockfile_path.exists()firstMaintenance
from apm_cli.commands.pack import ...from mid-file (line 313) to the top-level import block incli.pyyaml/UnpackResultimports fromtest_unpacker.pyandtest_pack_unpack_e2e.pyapm packandapm unpackreference sections todocs/cli-reference.mdType of change
Testing
4 new path-traversal unit tests added (2 packer, 2 unpacker). Full suite: 1387 passed.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.