test: address PR review feedback on primitives discovery/parser tests#268
Merged
danielmeppiel merged 2 commits intotest-assist/primitives-discovery-parser-coverage-da40935ebde67a0afrom Mar 12, 2026
Conversation
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Test Improver] Increase test coverage for primitives discovery and parser
test: address PR review feedback on primitives discovery/parser tests
Mar 12, 2026
danielmeppiel
merged commit 110e270
into
test-assist/primitives-discovery-parser-coverage-da40935ebde67a0a
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four review issues raised on the primitives discovery/parser test PR.
Changes
parser.py—_extract_primitive_name(): Addedagents/to the structured-directory list so.agent.mdsuffix is stripped consistently with.chatmode.md,.instructions.md, etc. Files under.apm/agents/or.github/agents/now yield just the agent name (e.g.reviewer, notreviewer.agent).Removed unused imports: Dropped
statanddiscover_primitivesfrom the test file's import block.Stable unreadability test: Replaced
os.chmod(0o000)(unreliable on Windows / elevated-privilege runners) withpatch("apm_cli.primitives.discovery.open", side_effect=PermissionError).Accurate test name: Renamed
test_unreadable_skill_md_warns_and_skips→test_parse_error_on_skill_md_warns_and_skips; the test exercises a parse failure, not file readability.Type of change
Testing
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.