fix(test): address PR #294 review — targeted teardown and stdout.close in finally

[danielmeppiel]

Summary

Addresses review feedback from #294 (two comments from Copilot reviewer).

Changes

1. process.stdout.close() moved to finally blocks — Previously only ran on the happy path. If an exception occurred while reading subprocess output, pipe handles would stay open, potentially causing the exact WinError 32 we're fixing. Now runs unconditionally in finally.

2. Targeted PermissionError handling in teardown — Replaced blanket ignore_errors=True with:

   • Catch PermissionError specifically
   • On Windows: retry once after 1s delay, then ignore_errors=True as last resort
   • On other platforms: re-raise so unexpected cleanup failures aren't masked

Review comments addressed

• fix(test): handle Windows file locking in integration test teardown #294 (comment)
• fix(test): handle Windows file locking in integration test teardown #294 (comment)

Ref #185

[Copilot]

Pull request overview

This PR updates the Windows-flaky auto-install E2E integration tests to be more robust during subprocess shutdown and test directory teardown, addressing feedback from PR #294.

Changes:

• Moves process.stdout.close() into finally blocks so pipe handles are closed even when exceptions occur while reading output.
• Replaces shutil.rmtree(..., ignore_errors=True) with targeted PermissionError handling in teardown, including a Windows-only retry with a short delay.

Comments suppressed due to low confidence (4)

tests/integration/test_auto_install_e2e.py:239

• Avoid using a bare except: here; it will also catch KeyboardInterrupt/SystemExit and can make test runs hard to abort. Prefer except Exception: (and optionally handle subprocess.TimeoutExpired explicitly if you want a distinct path).

        except:
            process.kill()
            process.wait()

tests/integration/test_auto_install_e2e.py:287

• Avoid using a bare except: here; it will also catch KeyboardInterrupt/SystemExit and can make test runs hard to abort. Prefer except Exception: (and optionally handle subprocess.TimeoutExpired explicitly if you want a distinct path).

        except:
            process.kill()
            process.wait()

tests/integration/test_auto_install_e2e.py:318

• Avoid using a bare except: here; it will also catch KeyboardInterrupt/SystemExit and can make test runs hard to abort. Prefer except Exception: (and optionally handle subprocess.TimeoutExpired explicitly if you want a distinct path).

        except:
            process.kill()
            process.wait()

tests/integration/test_auto_install_e2e.py:365

• Avoid using a bare except: here; it will also catch KeyboardInterrupt/SystemExit and can make test runs hard to abort. Prefer except Exception: (and optionally handle subprocess.TimeoutExpired explicitly if you want a distinct path).

        except:
            process.kill()
            process.wait()