Skip to content

fix: use _rmtree for Windows-safe directory cleanup in downloader #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 1 commit into from
Mar 14, 2026
Merged

fix: use _rmtree for Windows-safe directory cleanup in downloader #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/apm_cli/deps/github_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ def download_subdirectory_package(self, dep_ref: DependencyReference, target_pat

# If target exists and has content, remove it
if target_path.exists() and any(target_path.iterdir()):
shutil.rmtree(target_path)
_rmtree(target_path)
target_path.mkdir(parents=True, exist_ok=True)

# Copy subdirectory contents to target
Expand Down Expand Up @@ -1409,7 +1409,7 @@ def download_package(

# If directory already exists and has content, remove it
if target_path.exists() and any(target_path.iterdir()):
shutil.rmtree(target_path)
_rmtree(target_path)
target_path.mkdir(parents=True, exist_ok=True)

# Store progress reporter so we can disable it after clone
Expand Down
Loading