Skip to content

fix: release validation exits silently due to sourced set -e #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 1 commit into from
Mar 14, 2026
Merged

fix: release validation exits silently due to sourced set -e #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/test-dependency-integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
# Tests real dependency scenarios with actual GitHub repositories
# Used in CI pipeline for comprehensive dependency validation

set -euo pipefail
# NOTE: Do NOT use `set -e` here — this file is `source`d into
# test-release-validation.sh which deliberately avoids -e for its own
# error-handling strategy. Setting -e here would re-enable it for the
# sourcing script, causing silent early exits (e.g. `((count++))` when
# count is 0 returns exit-code 1 under -e).
set -uo pipefail

# Colors for output
RED='\033[0;31m'
Expand Down
12 changes: 0 additions & 12 deletions scripts/test-release-validation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,18 +94,6 @@ check_prerequisites() {
log_error "GitHub token setup failed"
return 1
fi

# Set up GitHub tokens for testing
# No specific NPM authentication needed for public runtimes
if [[ -n "${GITHUB_APM_PAT:-}" ]]; then
log_success "GITHUB_APM_PAT is set (APM module access)"
export GITHUB_APM_PAT="${GITHUB_APM_PAT}"
fi

if [[ -n "${GITHUB_TOKEN:-}" ]]; then
log_success "GITHUB_TOKEN is set (GitHub Models access)"
export GITHUB_TOKEN="${GITHUB_TOKEN}"
fi
}

# Test Step 2: apm runtime setup (both copilot and codex for full coverage)
Expand Down
Loading