Skip to content

[WIP] [#329] Strengthen apm audit with content scanning#339

Closed
Copilot wants to merge 2 commits intofeat/audit-unpack-sariffrom
copilot/sub-pr-330
Closed

[WIP] [#329] Strengthen apm audit with content scanning#339
Copilot wants to merge 2 commits intofeat/audit-unpack-sariffrom
copilot/sub-pr-330

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Thanks for the feedback on #330. I've created this new PR, which merges into #330, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #330
Triggering comment (#330 (comment)):

@copilot address PR review comments if they're legit and honoring developer experience + security


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
Copilot AI requested a review from danielmeppiel March 17, 2026 09:21
danielmeppiel added a commit that referenced this pull request Mar 17, 2026


Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
danielmeppiel added a commit that referenced this pull request Mar 17, 2026
…338

Collapse five #330 entries into one, add missing #332 auth-asymmetry
entry, and correct PR reference #339#338.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
danielmeppiel added a commit that referenced this pull request Mar 17, 2026
* Initial plan

* fix: preserve GHE custom domain host in lockfile download refs

When build_download_ref() constructed the locked download ref string,
it used only dep_ref.repo_url (e.g. "org/repo") without including
the host. When re-parsed by DependencyReference.parse(), this
defaulted to github.com, causing clone failures for GitHub Enterprise
custom domain dependencies.

Now includes dep_ref.host in the base ref when present, producing
e.g. "github.example.com/org/repo#commitsha" which correctly
resolves back to the enterprise host.

Fixes #339

Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>

* test: remove redundant assertion in GHE test

Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>

* fix: correct CHANGELOG — one entry per PR, add missing #332, fix #339#338

Collapse five #330 entries into one, add missing #332 auth-asymmetry
entry, and correct PR reference #339#338.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
Co-authored-by: danielmeppiel <dmeppiel@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants