fix: gh-aw compat test uses correct apm install syntax#360
Merged
danielmeppiel merged 1 commit intomainfrom Mar 18, 2026
Merged
fix: gh-aw compat test uses correct apm install syntax#360danielmeppiel merged 1 commit intomainfrom
danielmeppiel merged 1 commit intomainfrom
Conversation
The test used --isolated which is an apm-action flag, not an apm CLI flag. Fixed to create apm.yml and run 'apm install' directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the release-validation “GH-AW compatibility” check so it no longer uses --isolated (an apm-action flag) with the apm CLI, and instead runs an apm install flow intended to simulate tokenless installs.
Changes:
- Replaced
apm install <pkg> --isolatedwith a workflow that writes anapm.ymland runsapm installwith no args. - Updated the bundle-archive assertion to look for
build/*.tar.gz(matchingapm pack --archiveoutput).
Comment on lines
+363
to
+366
| # Create a minimal apm.yml like apm-action does in isolated mode | ||
| cat > apm.yml <<'APMYML' | ||
| dependencies: | ||
| - microsoft/apm-sample-package |
danielmeppiel
added a commit
that referenced
this pull request
Mar 18, 2026
v0.8.2 tag included a broken test script; tag is protected and cannot be moved. This release includes the test fix from #360. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix: the
test_ghaw_compattest in release validation used--isolatedwhich is anapm-actionflag, not anapmCLI flag. Fixed to createapm.ymland runapm installdirectly.Discovered via release validation failure in v0.8.2 pipeline run.