Skip to content

fix: ghaw compat test apm.yml uses correct manifest format#363

Merged
danielmeppiel merged 1 commit intomainfrom
fix/ghaw-test-apm-yml-format
Mar 18, 2026
Merged

fix: ghaw compat test apm.yml uses correct manifest format#363
danielmeppiel merged 1 commit intomainfrom
fix/ghaw-test-apm-yml-format

Conversation

@danielmeppiel
Copy link
Collaborator

The test apm.yml was missing version and used the wrong dependency structure. Fixed to match apm-action's generateManifest() format:

name: ghaw-compat-test
version: 1.0.0
dependencies:
  apm:
    - microsoft/apm-sample-package

Verified locally: tokenless install + pack succeeds with this format.

Match apm-action's generateManifest() format: name, version, and
dependencies under 'dependencies.apm' key (not top-level array).

Verified locally: tokenless install + pack succeeds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 18, 2026 19:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GH-AW compatibility portion of the release validation script so the generated apm.yml matches the manifest shape produced by apm-action (and APM’s documented manifest schema), ensuring the tokenless install + pack flow is exercised with a valid manifest.

Changes:

  • Add required version field to the generated apm.yml in the GH-AW compat test.
  • Fix dependencies to the correct object shape (dependencies.apm list) instead of a top-level list.
  • Adjust the inline comment to reflect that the manifest matches apm-action’s generateManifest() format.

@danielmeppiel danielmeppiel merged commit 043d295 into main Mar 18, 2026
16 checks passed
@danielmeppiel danielmeppiel deleted the fix/ghaw-test-apm-yml-format branch March 18, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants