[Test Improver] test: replace gc.collect+sleep teardown with shutil.rmtree(ignore_errors=True)

[danielmeppiel]

🤖 Test Improver — automated AI assistant for test improvements

Closes #185

Goal and Rationale

Several test classes used gc.collect() + time.sleep(0.1) in tearDown as a workaround for Windows file-lock timing issues with tempfile.TemporaryDirectory. This pattern was flagged during PR #181 review as fragile and adds unnecessary test latency (~100–500ms per test class).

This PR replaces that pattern with tempfile.mkdtemp() + shutil.rmtree(ignore_errors=True), which is:

• Faster: no artificial delays
• Cleaner: no gc hacks
• Correct: ignore_errors=True silently handles locked files on Windows without retrying or sleeping

Approach

For each affected class:

1. setUp: Replace tempfile.TemporaryDirectory() with tempfile.mkdtemp() (returns path string directly, no .name needed)
2. tearDown: Replace gc.collect() + sleep + .cleanup() with shutil.rmtree(path, ignore_errors=True)

Affected files:

File	Changes
tests/unit/test_deps.py	1 class: TestLoadApmConfig
tests/unit/test_env_variables.py	1 class: TestEnvironmentVariablesHandling
tests/unit/test_helpers.py	Removed empty tearDown (no temp dir was used)
tests/unit/test_vscode_adapter.py	4 classes fixed
tests/unit/workflow/test_workflow.py	Removed safe_rmdir helper; simplified 2 tearDowns

Test Status

✅ All 2261 tests pass

python3 -m uv run pytest tests/unit/ --no-header -q
# 2261 passed in 11.13s

Generated by Daily Test Improver · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/daily-test-improver.md@b87234850bf9664d198f28a02df0f937d0447295