fix: Windows test failures in config command and agents compiler#410
Merged
danielmeppiel merged 1 commit intomainfrom Mar 22, 2026
Merged
fix: Windows test failures in config command and agents compiler#410danielmeppiel merged 1 commit intomainfrom
danielmeppiel merged 1 commit intomainfrom
Conversation
Fix 7 pre-existing Windows CI test failures: - test_config_command.py (5 failures): PermissionError [WinError 32] when TemporaryDirectory cleanup runs while CWD is still inside it. Windows holds a handle on the CWD directory. Fix: os.chdir() back to original dir inside try/finally before the TemporaryDirectory context exits. - test_agents_compiler_coverage.py (2 failures): Path separator mismatch. relative_to() returns Path with OS-native separators (backslash on Windows), but assertions check for forward slashes. Fix: use .as_posix() in production code for consistent cross-platform summary output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows-specific unit test failures by ensuring temporary directories can be cleaned up (restoring CWD before TemporaryDirectory exit) and by normalizing path separators in distributed compilation summaries to be stable across platforms.
Changes:
- Update
apm configunit tests to alwayschdirback to the original working directory before temp directory cleanup. - Normalize relative path formatting in
AgentsCompilerdistributed summary generation viaPath.as_posix().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/test_config_command.py | Wraps test bodies in try/finally to restore CWD before TemporaryDirectory() cleanup on Windows. |
| src/apm_cli/compilation/agents_compiler.py | Uses .as_posix() for relative paths in distributed placement/summary output to avoid Windows backslash separators in summaries. |
This was referenced Mar 22, 2026
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 7 pre-existing Windows CI test failures (unrelated to #407).
Config command tests (5 failures)
Root cause:
PermissionError [WinError 32]—os.chdir(tmp_dir)insideTemporaryDirectory()context. On Windows, the OS holds a handle on the CWD, preventing__exit__from deleting the directory.Fix: Wrap test body in
try/finallytoos.chdir(self.original_dir)before theTemporaryDirectorycontext exits.Agents compiler summary tests (2 failures)
Root cause:
Path.relative_to()returns OS-native separators (sub\AGENTS.mdon Windows). Assertions check for forward-slash paths.Fix: Use
.as_posix()in production code (_generate_placement_summaryand_generate_distributed_summary) for consistent cross-platform output.Changes
src/apm_cli/compilation/agents_compiler.py—.as_posix()on relative paths in summary generationtests/unit/test_config_command.py—try/finallyto restore CWD before temp dir cleanupTesting