Skip to content

fix(templates): use canonical taxonomy labels in issue templates#958

Merged
danielmeppiel merged 1 commit intomainfrom
fix/issue-templates-canonical-labels
Apr 26, 2026
Merged

fix(templates): use canonical taxonomy labels in issue templates#958
danielmeppiel merged 1 commit intomainfrom
fix/issue-templates-canonical-labels

Conversation

@danielmeppiel
Copy link
Copy Markdown
Collaborator

TL;DR

Drop the deprecated labels pre-applied by issue templates and switch to the canonical APM taxonomy. Net effect for end users: opening a Bug or Feature template no longer applies orphaned/wrong labels; the daily Triage Panel sweep handles classification from there.

Problem (WHY)

Both issue templates pre-applied labels that were both deprecated and wrong for the current automation:

  • needs-triage is deprecated (slated for removal in 0.10.0) and does NOT trigger the Triage Panel fast-path — the workflow only fires on status/needs-triage. Triaged issues ended up carrying both needs-triage and status/triaged because the panel never removes the legacy label.
  • bug and enhancement are also deprecated; the canonical types in the panel's add-labels allow-list are type/bug and type/feature.

Templates are the most-used path to file an issue, so this drift was producing inconsistent label state on most new issues.

Approach (WHAT)

Template Before After
bug_report.md bug, needs-triage type/bug
feature_request.md enhancement, needs-triage type/feature

needs-triage is dropped entirely — new issues are picked up by the daily Triage Panel sweep, which is the design we explicitly shipped in #954 (cost-bounded, exploit-resistant). Maintainers who want immediate triage on a specific issue still have the one-click fast-path: apply status/needs-triage manually.

Implementation (HOW)

Two-line frontmatter edits in .github/ISSUE_TEMPLATE/{bug_report,feature_request}.md. No workflow or skill changes.

Trade-offs

  • No more needs-triage auto-apply. New issues sit unlabeled (beyond type/*) for up to ~24h until the daily sweep. Acceptable given the architecture decision in feat(ci): automate apm-triage-panel on new and reopened issues #954 — auto-fast-path on every new issue reintroduces the unbounded-cost / open-close exploit surface.
  • Existing 20 open issues still carry the legacy needs-triage label. Out of scope for this PR; they'll either be cleaned up when 0.10.0 removes the deprecated label, or via a one-shot manual sweep.

Validation

  • git diff confirms only frontmatter labels: lines changed; template body untouched.
  • Verified type/bug and type/feature are in the live add-labels.allowed list at .github/workflows/triage-panel.md (so the panel respects user-applied type labels rather than dropping them).

How to test

  1. After merge, click "New issue" in the GitHub UI and pick "Bug report" — confirm only type/bug is pre-applied.
  2. Same for "Feature request" — confirm only type/feature.
  3. Wait for the next daily sweep (or apply status/needs-triage for the fast-path) and confirm the panel applies the rest of the taxonomy plus status/triaged.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

The bug and feature templates pre-applied three deprecated labels:
- `needs-triage` (replaced by `status/needs-triage`)
- `bug` (replaced by `type/bug`)
- `enhancement` (replaced by `type/feature`)

All three are slated for removal in 0.10.0.

Beyond deprecation, `needs-triage` was actively wrong: it does not
trigger the Triage Panel fast-path (only `status/needs-triage` does),
and the panel never removes it, so triaged issues ended up with both
`needs-triage` and `status/triaged`.

This change drops `needs-triage` entirely (new issues are picked up
by the daily sweep, by design — the fast-path is an opt-in maintainer
signal, not a default) and switches `bug`/`enhancement` to their
canonical `type/*` equivalents, which are in the panel's add-labels
allow-list.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 26, 2026 17:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub issue templates to stop auto-applying deprecated/legacy labels and instead apply the canonical APM taxonomy type/* labels, aligning new issues with the Triage Panel workflow’s label allow-list and behavior.

Changes:

  • Update Feature request template to apply type/feature instead of enhancement, needs-triage.
  • Update Bug report template to apply type/bug instead of bug, needs-triage.
Show a summary per file
File Description
.github/ISSUE_TEMPLATE/feature_request.md Switches template-applied labels to canonical type/feature.
.github/ISSUE_TEMPLATE/bug_report.md Switches template-applied labels to canonical type/bug.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@danielmeppiel danielmeppiel merged commit 361f720 into main Apr 26, 2026
19 checks passed
@danielmeppiel danielmeppiel deleted the fix/issue-templates-canonical-labels branch April 26, 2026 17:14
@danielmeppiel danielmeppiel mentioned this pull request Apr 27, 2026
3 tasks
danielmeppiel added a commit that referenced this pull request Apr 27, 2026
* chore(release): cut 0.9.4

CHANGELOG entry for 0.9.4 covers all 7 PRs merged since v0.9.3:

- #974 SKILL_BUNDLE day-0 install parity (Added)
- #954 automate apm-triage-panel workflow (Added)
- #970 python-architect mermaid classDiagram trap (Changed)
- #911 REQUESTS_CA_BUNDLE TLS validation (Fixed)
- #971 triage-panel project-sync dispatch (Fixed)
- #910 CLI consistency cleanup (Fixed)
- #958 issue templates label taxonomy (Fixed)
- #953 docs auto-deploy after bot-cut releases (Fixed)

Open milestone 0.9.4 issues (41) reassigned to 0.9.5.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(changelog): tighten 0.9.4 entries (so-what for developers)

Refactor per Keep-a-Changelog spirit: lead with developer impact,
trim agent-internals prose, group maintainer-only changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(changelog): add #660 install.sh air-gapped entry to 0.9.4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants