Skip to content

fix(tests): force UTF-8 in non-ASCII SKILL.md fixture (Windows CI hotfix) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 1 commit into from
Apr 27, 2026
Merged

fix(tests): force UTF-8 in non-ASCII SKILL.md fixture (Windows CI hotfix) #979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/unit/test_skill_bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ def test_non_ascii_frontmatter_warning(self, tmp_path):
sd = skills_dir / "unicode-skill"
sd.mkdir()
(sd / "SKILL.md").write_text(
"---\nname: unicode-skill\ndescription: Ünïcödé description\n---\n# x\n"
"---\nname: unicode-skill\ndescription: Ünïcödé description\n---\n# x\n",
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file contains non-ASCII characters directly in the Python string literal ("Unic..." with accented letters). Repo guidelines require source files to remain printable ASCII; please spell these characters using Unicode escape sequences (e.g., \u00dc) so the source stays ASCII while still writing non-ASCII content into SKILL.md via UTF-8.

Copilot generated this review using guidance from repository custom instructions.
encoding="utf-8",
)
result = validate_apm_package(tmp_path)
assert result.is_valid # warnings don't fail validation
Expand Down
Loading