Skip to content

fix(docs): deploy on tag push, not on the unreachable workflow_call branch #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 3 commits into from
Apr 27, 2026
Merged

fix(docs): deploy on tag push, not on the unreachable workflow_call branch #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc0dae4
fix(docs): deploy on tag push, not on the unreachable workflow_call b…
danielmeppiel Apr 27, 2026
b5046a2
Merge branch 'main' into fix/docs-deploy-workflow-call
danielmeppiel Apr 27, 2026
2e1cbfc
Update CHANGELOG.md
danielmeppiel Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,15 @@ jobs:
run: npm run build

- name: Upload build artifacts
# NOTE: in a reusable workflow, github.event_name reflects the CALLER's
# event (here: 'push' of a v* tag from build-release.yml), NOT
# 'workflow_call'. Detect the workflow_call invocation via the tag-push
# context instead. PR runs (event_name == 'pull_request') correctly
# build-only because none of the three branches match.
if: |
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'release' && github.event.release.prerelease == false) ||
(github.event_name == 'workflow_call' && inputs.is_prerelease == false)
(github.event_name == 'push' && github.ref_type == 'tag' && inputs.is_prerelease == false)
uses: actions/upload-pages-artifact@v3
with:
path: docs/dist
Expand All @@ -66,10 +71,12 @@ jobs:
needs: build
# Only stable releases (or manual dispatch) update the public docs site,
# so prerelease tags (vX.Y.Z-rc1, etc.) don't clobber published docs.
# NOTE: in a reusable workflow, github.event_name reflects the CALLER's
# event ('push' of a v* tag from build-release.yml), NOT 'workflow_call'.
if: |
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'release' && github.event.release.prerelease == false) ||
(github.event_name == 'workflow_call' && inputs.is_prerelease == false)
(github.event_name == 'push' && github.ref_type == 'tag' && inputs.is_prerelease == false)
runs-on: ubuntu-latest
permissions:
pages: write
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Docs site auto-deploys again after bot-cut releases by correctly detecting tag-push context in `docs.yml`. (#953)

## [0.9.4] - 2026-04-27

### Added
Expand Down
Loading