Skip to content

Use node to resolve react-native package path #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youedd wants to merge 1 commit into from
Closed

Use node to resolve react-native package path #2284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/commands/codepush/lib/react-native-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const plist = require("plist");
const g2js = require("gradle-to-js/lib/parser");
const properties = require("properties");
import * as childProcess from "child_process";
import { directoryExistsSync } from "../../../util/misc/fs-helper";

export interface VersionSearchParams {
os: string; // ios or android
Expand Down Expand Up @@ -541,7 +542,7 @@ async function getHermesCommand(gradleFile: string): Promise<string> {
}
};
// Hermes is bundled with react-native since 0.69
const bundledHermesEngine = path.join("node_modules", "react-native", "sdks", "hermesc", getHermesOSBin(), getHermesOSExe());
const bundledHermesEngine = path.join(getReactNativePackagePath(), "sdks", "hermesc", getHermesOSBin(), getHermesOSExe());
if (fileExists(bundledHermesEngine)) {
return bundledHermesEngine;
}
Expand All @@ -561,7 +562,7 @@ async function getHermesCommand(gradleFile: string): Promise<string> {

function getComposeSourceMapsPath(): string {
// detect if compose-source-maps.js script exists
const composeSourceMaps = path.join("node_modules", "react-native", "scripts", "compose-source-maps.js");
const composeSourceMaps = path.join(getReactNativePackagePath(), "scripts", "compose-source-maps.js");
if (fs.existsSync(composeSourceMaps)) {
return composeSourceMaps;
}
Expand All @@ -570,12 +571,22 @@ function getComposeSourceMapsPath(): string {

function getCliPath(): string {
if (process.platform === "win32") {
return path.join("node_modules", "react-native", "local-cli", "cli.js");
return path.join(getReactNativePackagePath(), "local-cli", "cli.js");
}

return path.join("node_modules", ".bin", "react-native");
}

function getReactNativePackagePath(): string {
const result = childProcess.spawnSync("node", ["--print", "require.resolve('react-native/package.json')"]);
const packagePath = path.dirname(result.stdout.toString());
if (directoryExistsSync(packagePath)) {
return packagePath;
}

return path.join("node_modules", "react-native");
}

export function isValidOS(os: string): boolean {
switch (os.toLowerCase()) {
case "android":
Expand Down