Use node to resolve react-native package path #2305
Merged
AnatolyPristensky merged 2 commits intomasterfrom Apr 28, 2023
Merged
Use node to resolve react-native package path #2305AnatolyPristensky merged 2 commits intomasterfrom
AnatolyPristensky merged 2 commits intomasterfrom
Conversation
Priskorn
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were facing issues with the appcenter cli after migrating our react-native project to a mono-repository.
The cli is looking for react-native package is in the project node_modules folder instead of the root node_modules, which leads to errors.
This PR aims to solve that by using node's
require.resolveto find the package path.